Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support off action #124

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Support off action #124

wants to merge 1 commit into from

Conversation

k-keiichi-rh
Copy link
Contributor

This PR is to support off action.

The following is the FAR workflow with off action:

  1. FAR adds NoExecute taint to the failed node
  2. FAR powers off the failed node via the Fence Agent
  3. FAR deletes workloads in the failed node
  4. [User Intervention] Admins turn the failed node on after they check the failed node has been recovered.
  5. After the failed node becomes healthy, NHC deletes FenceAgentsRemediation CR, the NoExecute taint in Step 2 is removed, and the node becomes schedulable again

In step 4, if users want to do troubleshooting on the failed node, they need to manually add the proper taints before turning on the failed node. The document pr is tracked in https://issues.redhat.com/browse/ECOPROJECT-1756.

ECOPROJECT-1471

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k-keiichi-rh
Once this PR has been reviewed and has the lgtm label, please assign razo7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

Hi @k-keiichi-rh. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit mshitrit marked this pull request as draft January 18, 2024 08:43
@mshitrit
Copy link
Member

Hi @k-keiichi-rh , since this PR is still a WIP I've converted it to a "draft" PR.
We usually create our PRs as such in order to save cloud resources (draft PR doesn't run e2e tests automatically).

We try to follow this process:

  • create draft PR
  • run a single e2e test
  • review the PR
  • once the test passes and the PR is lgtm we convert it to a none draft PR and run the rest of the e2e tests.

Let me know if that makes sense.

@mshitrit
Copy link
Member

/test 4.14-openshift-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@k-keiichi-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.14-openshift-e2e c5eb860 link true /test 4.14-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@razo7
Copy link
Member

razo7 commented Jan 18, 2024

/test 4.13-openshift-e2e

slintes
slintes requested changes Jan 23, 2024
View reviewed changes
controllers/fenceagentsremediation_controller_test.go
@@ -99,6 +99,47 @@ var _ = Describe("FAR Controller", func() {
})

Context("buildFenceAgentParams", func() {
Context("build fence agent params", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this Context has the same description as the above Context, can we have a better description please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will change the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slintes slintes slintes requested changes

@beekhof beekhof Awaiting requested review from beekhof

@mshitrit mshitrit Awaiting requested review from mshitrit

Assignees

@slintes slintes

Labels
do-not-merge/work-in-progress needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-keiichi-rh @mshitrit @razo7 @slintes